feat(@angular-devkit/build-angular): support component style budgets in esbuild builders#25976
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Oct 9, 2023
Merged
Conversation
clydin
added
the
action: review
…in esbuild builders The `anyComponentStyle` budget type is now supported when using bundle budgets in the esbuild- based builders (`browser-esbuild`/`application`). The configuration and behavior are intended to match that of the Webpack-based builder (`browser`). With this addition, the bundle budget feature is now at feature parity with the Webpack-based builder. The implementation of this budget type requires less code than the Webpack implementation due to the component stylesheet information being present in the application's output metadata. This removes the need for a custom budget plugin to extract the stylesheet size information during the build.
clydin
force-pushed
the
esbuild/budgets-component-styles
branch
from
84723d3 to
b92497f
Compare
alan-agius4
approved these changes
Oct 9, 2023
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
So much simpler with Esbuild!
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
anyComponentStylebudget type is now supported when using bundle budgets in the esbuild-based builders (browser-esbuild/application). The configuration and behavior are intended to match that of the Webpack-based builder (browser). With this addition, the bundle budget feature is now at feature parity with the Webpack-based builder. The implementation of this budget type requires less code than the Webpack implementation due to the component stylesheet information being present in the application's output metadata. This removes the need for a custom budget plugin to extract the stylesheet size information during the build.